Skip to content

ZFIN-9622: Handle edge case for manually curated UniProt accessions flagged for deletion #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

rtaylorzfin
Copy link
Collaborator

Handle edge case for manually curated UniProt accessions flagged for deletion

  • Added logic to detect manually curated UniProt accessions that would otherwise be lost
    • Introduced new SubType: MANUALLY_CURATED_ACCESSION_WOULD_BE_LOST
    • Enhanced CheckLostUniprotsForObsoletesHandler to review this subtype
    • These accessions are included in the report for curator review
  • Improved log messages
  • Improve efficiency with reuse of reference database object

…deletion

- Added logic to detect manually curated UniProt accessions that would otherwise be lost
	- Introduced new SubType: MANUALLY_CURATED_ACCESSION_WOULD_BE_LOST
	- Enhanced CheckLostUniprotsForObsoletesHandler to review this subtype
	- These accessions are included in the report for curator review
- Improved log messages
- Improve efficiency with reuse of reference database object
Copy link
Collaborator

@cmpich cmpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rtaylorzfin rtaylorzfin merged commit ee69d15 into ZFIN:main Apr 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants