Support user-specified image pull policy #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 56.60% 56.89% +0.28%
==========================================
Files 62 63 +1
Lines 3132 3164 +32
==========================================
+ Hits 1773 1800 +27
- Misses 1359 1364 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is needed to access the newly added types in the client package.
AdrianoKF
reviewed
Oct 25, 2024
This commit adds support for pull policies in the runners. The job submission endpoint passes the pull policy to the runner, by default the policy is set to `Always` to prevent issues with stale images. The e2e test has been updated to pass `IfNotPresent` as the pull policy, since the job image for the test suite is built locally and cannot be pulled from a registry.
The `Runner` interface has been changed to accept an `ImageRef`, instead of importing the (useless) `Image` type from the client package. Co-authored-by: Max Mynter <maxmynter@users.noreply.github.com>
AdrianoKF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
Todo's
IfNotPresentas pull policy to support running e2e tests in cluster with no image registry available.../runner/ray.py: 46.../guides/exeution-modes.md)Notes
I have thought a bit about where to put the pull policy. Candidates were the
ImageorImageOptions, or a standalone argument.I decided on the former as
ImageOptionsare defined when theJobis defined but a user may want to change the pull policy without touching the job. The pull policy is more ephemeral thanImageOptions.As we build up the
Imageon the backend we can at that point inject the pull policy.A separate object is imo not warranted as we never need a policy without an association to an image.