Add support for Kueue scheduling options to RayJob runner #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjng
approved these changes
Apr 30, 2024
| from jobs.utils.helpers import remove_none_values | ||
|
|
||
|
|
||
| def assert_kueue_localqueue(namespace: str, name: str) -> bool: |
There was a problem hiding this comment.
Nit: I don't love assert as the leading part of these functions, since they do not use assertions but API lookups (which is of course 1000x better). But at this time it's an internal detail, so I'm good with leaving it like this.
maxmynter
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Kueue
SchedulingOptionsin the job options to theRayJobrunner.This enables job priorities and preemption to be used by Ray jobs if Kueue is available in the Kubernetes cluster.
Internally, the
utilmodule has been refactored into a proper package for better usability, since it was growing into a mixed bag of unrelated functions.