Add final inspections sketches as a separate category #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pete-Y-CS
force-pushed
the
main
branch
2 times, most recently
from
cbe6db9 to
e1e4095
Compare
src/lib/browse/schemes/data.ts
Outdated
| lcwipGj.schemes[scheme_reference] = scheme; | ||
| } else { | ||
| } else if (scheme.browse?.sketch_source == "ATF assessment") { |
There was a problem hiding this comment.
Do we want this to be strict equality as with the first if branch?
src/lib/browse/schemes/data.ts
Outdated
| atfGj.schemes[scheme_reference] = scheme; | ||
| } else if (scheme.browse?.sketch_source == "Final inspection sketches") { |
There was a problem hiding this comment.
Same question as above
|
I tried to do the refactor suggested in conversation - not working at first blush so gonna merge this and see if we can't resolve that down the line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.