Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
π Description
This PR extends sideload functionality:
sideloaded
on query builder topublic
so it can be retrieved when querying.On some projects we use
sideload
for getting translation data for localized content. When we filter the content by search phrase we need to check what locale (set insideloaded
) is used for the query to run the condition for correct locale. In order for this to work we need to be able to retrievesideloaded
in query builder. It's also very helpful to be able to add extra data to alreadysideloaded
data, when there is other chained functionality, so it won't get replaced.This PR enhances the
sideload
functionality to support it.PS: This PR also uses
@japa/expect-type
, so I based it off #1097 and it should be merged first.π Checklist