docs: add tx types to transactions_spec.yaml #2119
Conversation
| @@ -1,4 +1,30 @@ | |||
| schemas: | |||
| ChannelId: | |||
| type: string | |||
| example: ch_2VfzXmCRZepB3ichPf3WTt2uf8zMqsyY3cZWg8k1vt3xcu8L8V | |||
There was a problem hiding this comment.
| example: ch_2VfzXmCRZepB3ichPf3WTt2uf8zMqsyY3cZWg8k1vt3xcu8L8V | |
| pattern: ^ch_\w{38,50}$ | |
| example: ch_2VfzXmCRZepB3ichPf3WTt2uf8zMqsyY3cZWg8k1vt3xcu8L8V |
so SDK can know that it is ch_-prefixed
docs/swagger_v3/channels.spec.yaml
Outdated
| type: object | ||
| required: | ||
| - responder_id | ||
| - initiator_id | ||
| - round | ||
| properties: | ||
| initiator_id: | ||
| $ref: '#/components/schemas/AccountAddress' | ||
| responder_id: | ||
| $ref: '#/components/schemas/AccountAddress' | ||
| round: | ||
| type: integer |
There was a problem hiding this comment.
| type: object | |
| required: | |
| - responder_id | |
| - initiator_id | |
| - round | |
| properties: | |
| initiator_id: | |
| $ref: '#/components/schemas/AccountAddress' | |
| responder_id: | |
| $ref: '#/components/schemas/AccountAddress' | |
| round: | |
| type: integer | |
| allOf: | |
| - '#/components/schemas/ChannelResponderInitiator' | |
| - type: object | |
| required: | |
| - round | |
| properties: | |
| round: | |
| type: integer |
| properties: | ||
| aexn_type: | ||
| type: string | ||
| example: aex9 |
There was a problem hiding this comment.
| example: aex9 | |
| example: aex9 | |
| enum: | |
| - aex9 |
docs/swagger_v3/contracts.spec.yaml
Outdated
| type: array | ||
| items: | ||
| type: object | ||
| properties: |
There was a problem hiding this comment.
| properties: | |
| required: | |
| - type | |
| - value | |
| properties: |
docs/swagger_v3/contracts.spec.yaml
Outdated
| type: array | ||
| items: | ||
| type: object | ||
| properties: |
There was a problem hiding this comment.
| properties: | |
| required: | |
| - address | |
| - data | |
| - topics | |
| properties: |
| - args | ||
| - auth_fun_name | ||
| - contract_id | ||
| - gas_used | ||
| - return_type |
There was a problem hiding this comment.
the only auth_fun_name is not defined in MdwContractCreateExtras
There was a problem hiding this comment.
Can you elaborate this, I don't think I understood you
There was a problem hiding this comment.
I meant to reuse some of the contract definitions, but maybe it isn't worth it 🤷♀️
| gas_used: | ||
| type: integer | ||
| return_type: | ||
| type: string |
There was a problem hiding this comment.
| type: string | |
| type: string | |
| enum: | |
| - ok |
| gas_used: | ||
| type: integer | ||
| return_type: | ||
| type: string |
There was a problem hiding this comment.
| type: string | |
| type: string | |
| enum: | |
| - ok |
| - gas_used | ||
| - return_type |
| required: | ||
| - type | ||
| type: object |
There was a problem hiding this comment.
| required: | |
| - type | |
| type: object |
type already marked as required at line 7 🤔
| - aexn_type | ||
| - gas_used | ||
| - return_type | ||
| - ttl |
There was a problem hiding this comment.
Don't mess with ttl, just preserve the node behaviour and types
| - "topic2" | ||
| result: | ||
| type: string | ||
| example: ok |
There was a problem hiding this comment.
Isn't it also an ok | revert | error enum?
| - args | ||
| - auth_fun_name | ||
| - contract_id | ||
| - gas_used | ||
| - return_type |
There was a problem hiding this comment.
I meant to reuse some of the contract definitions, but maybe it isn't worth it 🤷♀️
| enum: | ||
| - ok | ||
| - error | ||
| - revert |
There was a problem hiding this comment.
contract create can't be reverted as I know
Added the missing fields in the swagger for transactions and added the ttl field to the transactions as in the docs
resolves: #2115