-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'bun up' to 'bun db' #141
Conversation
- Changed the script name from 'up' to 'db' in package.json - Updated README and getting-started.md to reflect the new command for spinning up the Postgres+Bun container
WalkthroughThis pull request updates the command used to spin up the Postgres+Bun container. The command is changed from Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about removing the app
service from the docker-compose file? I think that is only for devcontainers, but we don't really use it.
- Deleted the app service definition, including image, volumes, command, and network settings, to streamline the Docker setup.
Description
Update the "bun up" command to "bun db" since it's used to spin up a db container. It's a better name. If we use "bun docs" to spin up a docs server, we should use "bun db" to spin up a db server.
PR Checklist
bun docs
Summary by CodeRabbit
bun db
command for initiating the database service, replacing the previousbun up
command in both the quickstart and getting-started guides.bun db
command.app
service configuration from the Docker Compose setup.