Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove lock #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove lock #4

wants to merge 1 commit into from

Conversation

chenkovsky
Copy link

itertools.count is thread safe. we can use this to remove lock

@alexferl
Copy link
Owner

I vaguely remember reading about this when I was porting it and if I recall correctly, itertools doesn't guarantee thread safety and is only thread safe because of the GIL in the CPython implementation. Is the lock that slow that you require a lockless implementation like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenkovsky @alexferl