Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Don't shadow --name option for add subcomands #129

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

samueldr
Copy link
Contributor

@samueldr samueldr commented Mar 31, 2025

Fixes #128.

To be brutally honest: I did not check for pypi, but given the way Rust is, I have full confidence that it was broken like channel was, and that the fix will work.

And to be clear: I have verified that the changed implementation works for the channel type.

@piegamesde
Copy link
Collaborator

How, that's a hell of a footgun clap fired there

@piegamesde piegamesde merged commit 4d1b291 into andir:master Mar 31, 2025
1 check passed
@samueldr samueldr deleted the fix/channel-names branch March 31, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel type pins can't be named with 0.3.0
2 participants