fix batch create stream and make SetHostSocket thread safe #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenrryyou
force-pushed
the
fix_batch_create_stream
branch
4 times, most recently
from
5b8021a to
41f3c2c
Compare
wwbmmm
reviewed
Apr 6, 2025
src/brpc/stream_impl.h
Outdated
| @@ -134,6 +134,7 @@ friend struct butil::DefaultDeleter<Stream>; | |||
| butil::IOBuf *_pending_buf; | |||
| int64_t _start_idle_timer_us; | |||
| bthread_timer_t _idle_timer; | |||
| std::once_flag set_host_socket_flag; | |||
jenrryyou
force-pushed
the
fix_batch_create_stream
branch
from
41f3c2c to
882977b
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
修复#2754合入后发现的问题：
有一处存在use after free；
SetHostSocket可能会并发调用，增加并发安全性；
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
无
Breaking backward compatibility(向后兼容性):
完全兼容
Check List: