mod_ssl: Check the SSLProtocol directive when loading the configuration #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the SSLProtocol directive was checked at runtime. Apache quit if the directive contained an invalid combination of protocols, and logged the message "AH02231: No SSL protocols available [hint: SSLProtocol]". With this change, most invalid SSLProtocol directives are detected when checking the configuration, e.g. with "httpd -t -f httpd.conf". Examples of invalid protocol combinations that are catched: * SSLProtocol "-TLSv1" * SSLProtocol "-all" * SSLProtocol "TLSv1.2 -TLSv1.2"
|
Looks like this was merged from 2.4 and added the new check in the wrong function but it's a trivial fix. Thanks for the PR! |
|
@notroj You're right... thank you for fixing the commit and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SSLProtocol directive was checked at runtime. Apache quit if the directive contained an invalid combination of protocols, and logged the message "AH02231: No SSL protocols available [hint: SSLProtocol]".
With this change, most invalid SSLProtocol directives are detected when checking the configuration, e.g. with "httpd -t -f httpd.conf".
Examples of invalid protocol combinations that are catched: