KNOX-3113: Changed the default HSTS header for global config, skips c… #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opying the HSTS header if its already set
pzampino
approved these changes
Mar 26, 2025
moresandeep
pushed a commit
to moresandeep/knox
that referenced
this pull request
Mar 31, 2025
…opying the HSTS header if its already set (apache#1008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…opying the HSTS header if its already set
What changes were proposed in this pull request?
KNOX-3111 introduced a bug. If the global settings for HSTS is set and the topology wide setting is disabled the HSTS header is duplicated in case the proxied service also adds its own header. This PR adds verification to the response header copy method that checks whether this header is already set or not.
Also added
includeSubDomainsto the default global setting.How was this patch tested?
New unit tests
Manually tests