Skip to content

KNOX-3103 - Move RegEx Tests from KnoxSSO module to RegExUtils #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

lmccay
Copy link
Contributor

@lmccay lmccay commented Feb 27, 2025

What changes were proposed in this pull request?

Recently added a test to the KnoxSSO suite for additional tests for the regex whitelist for redirects. The regex tests actually belong with the regexutils class. This patch will move them there as appropriate.

How was this patch tested?

Unit tests run in new location and all existing tests run.

Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; shipt it :)

@lmccay lmccay merged commit 85c5557 into apache:master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants