KNOX-3102 - Complete Auditing in RemoteAuthProvider #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moresandeep
requested changes
Feb 28, 2025
| @@ -70,8 +71,11 @@ public class RemoteAuthFilter implements Filter { | |||
| private static final String CONFIG_USER_HEADER = "remote.auth.user.header"; | |||
| private static final String CONFIG_GROUP_HEADER = "remote.auth.group.header"; | |||
| private static final String DEFAULT_CONFIG_USER_HEADER = "X-Knox-Actor-ID"; | |||
| private static final String DEFAULT_CONFIG_GROUP_HEADER = "X-Knox-Actor-Groups-*"; | |||
| private static final String DEFAULT_CONFIG_GROUP_HEADER = "X-Knox-Actor-Groups-1"; | |||
There was a problem hiding this comment.
Shouldn't this property X-Knox-Actor-Groups-* ?
There was a problem hiding this comment.
hmmm - yes. I think I hit CMD+Z too many times. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The initial implementation of the RemoteAuthProvider only has the initial access level audit. We need to add not only the result of the authentication attempt but also add the correlation id for the audit entries to the call to the remote auth service so that the audit logs can be correlated.
How was this patch tested?
Added new unit tests and ran all existing tests.
Manually tested with a single instance and traced the call from through the initial topology and the "remote" endpoint. Note the correlation id is the same for all of the entries. This will follow across instances as well.