-
Notifications
You must be signed in to change notification settings - Fork 825
header_rewrite: Add set-plugin-cntl #12125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tls_conn_timeout failed |
[approve ci autest 0] |
================== ===================== ============================================================================================= | ||
Controller Operators/Conditions Description | ||
================== ===================== ============================================================================================= | ||
TIMEZONE ``NOW`` If ``GMT`` is passed, the operators and conditions use GMT regardles of the timezone setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOW is not a valid timezone, maybe put LOCAL
there instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOW is not a default value. There are three columns and the second column shows the operators and conditions that are controlled by a controller.
const std::string &name = p.get_arg(); | ||
const std::string &value = p.get_value(); | ||
|
||
if (name == "TIMEZONE") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOCAL
and GMT
look like the only two possible values, should add that to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already written on the docs.
I was surprised that
%{NOW}
in header rewrite rules does not always use GMT.trafficserver/doc/admin-guide/plugins/header_rewrite.en.rst
Lines 560 to 565 in ce7287b
The new operator,
set-plugin-cntl
, enables users to change fundamental behavior of header_rewrite plugin. I addedTIMEZONE
controller for now. You can use it like below to use GMT regardless of system setting.I made this new operator applicable for other things because there's at least one more thing I want to change.