[CI] OASIS-to-BIDS : Add option --subjects-list and its functionality for oasis-to-bids converter #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the work @Adam-Ismaili-92 ! I have a few suggestions, let me know what you think.
Edit : Maybe go to the last comment first
Adam-Ismaili-92
force-pushed
the
feature-1467
branch
from
041d128 to
de6f4d0
Compare
There was a problem hiding this comment.
Thanks for the work @Adam-Ismaili-92 ! Just a few more details but for the code part it should be good to go.
There was a problem hiding this comment.
Thanks for the work @Adam-Ismaili-92 . Just one last detail before merging
AliceJoubert
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1467