Fix Clippy warnings: type complexity, needless borrow, etc. #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
r1cs_to_qap.rs
return type from a large tuple into aQAPTuple<F>
type alias (resolving Clippy’stype_complexity
).evaluate_constraint
(fixing Clippy’sneedless_borrow
).Ok(...)?
usage inlib.rs
(resolvingneedless_question_mark
).clippy::too_many_arguments
where needed, to silence that lint without breaking API.Why
-D warnings
.Testing
cargo clippy --all -- -D warnings
that no warnings remain.