document packages #2316
Merged
document packages #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
miparnisari
force-pushed
the
document-packages
branch
from
72e4444 to
da4e2dd
Compare
miparnisari
force-pushed
the
document-packages
branch
from
da4e2dd to
b630311
Compare
miparnisari
commented
Apr 10, 2025
| @@ -1,3 +1,4 @@ | |||
| // Package developmentmembership defines operations with sets. To be used in tests only. | |||
There was a problem hiding this comment.
I hope i got this right... developmentmembership wasn't a clear name 😅
miparnisari
force-pushed
the
document-packages
branch
from
b630311 to
5854f58
Compare
miparnisari
force-pushed
the
document-packages
branch
2 times, most recently
from
f3b55ae to
3593d01
Compare
miparnisari
force-pushed
the
document-packages
branch
from
3593d01 to
7c965ca
Compare
vroldanbet
previously approved these changes
Apr 10, 2025
miparnisari
force-pushed
the
document-packages
branch
from
7c965ca to
a416199
Compare
miparnisari
force-pushed
the
document-packages
branch
from
a416199 to
d09562a
Compare
miparnisari
force-pushed
the
document-packages
branch
from
d09562a to
a289b62
Compare
tstirrat15
approved these changes
Apr 15, 2025
| @@ -44,7 +44,7 @@ func (ss SubjectSet) UnionWithSet(other SubjectSet) error { | |||
| return ss.BaseSubjectSet.UnionWithSet(other.BaseSubjectSet) | |||
| } | |||
|
|
|||
| // WithParentCaveatExpression returns a copy of the subject set with the parent caveat expression applied | |||
| // WithParentCaveatExpression returns a copy of the subject set with the parent caveat expression applied | |||
| @@ -0,0 +1,2 @@ | |||
| // Package servicespecific defines middleware that injects other middlewares. | |||
There was a problem hiding this comment.
Suggested change
| // Package servicespecific defines middleware that injects other middlewares. | |
| // Package servicespecific defines middleware that injects other middlewares for service-specific use cases. |
Comment on lines
+1
to
+2
| // Package development contains code that runs in the Playground. | ||
| package development |
There was a problem hiding this comment.
I think this is also used by zed. Maybe "used by other libraries to facilitate schema development?"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I glazed over the code to see what is implemented and to get a feeling of the overall organization. (And I fixed some typos along the way)
What stood out to me is that there are lot of folders with the same name within
internaland withinpkg. The line of what goes where seems blurry. E.g.:graph(only 2 files inpkg?)caveats. And, surprisingly, differentEvaluation Resultsstructs exist in both foldersnamespace/schemaI believe that this could be simplified by merging folders, but this could break existing consumers of
pkgif we move tointernal. Who are the code consumers ofpkgtoday? Do we provide guarantees on its stability?Other things I noticed:
I'd be happy to submit follow-up PRs for all these things 😄