[MDS-6429] Fix mine compliance filters #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sggerard
added
the
👍 Ready for review
taraepp
reviewed
Apr 7, 2025
services/core-web/src/components/mine/Compliance/MineComplianceInfo.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Apr 7, 2025
services/core-web/src/components/mine/Compliance/MineComplianceInfo.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Apr 7, 2025
services/core-web/src/components/mine/Compliance/MineComplianceInfo.tsx
Outdated
Show resolved
Hide resolved
|
|
|
taraepp
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6429
All of the filters on the inspection orders didn't handle nulls, I'm not entirely sure how they ever worked. Easy fix (slap a lodash isEmpty() on the front). Also decided to update the class to Typescript. I've tested locally by intercepting the browser api calls and everything appears to work now :)