Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFI Processing updates #4354

Merged
merged 12 commits into from
Mar 20, 2025
Merged

HFI Processing updates #4354

merged 12 commits into from
Mar 20, 2025

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Mar 19, 2025

  • Use snow for_date to grab the data closest to the sfms run_datetime
  • Remove run_date altogether

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (94f5c6f) to head (60f7699).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4354   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files         265      265           
  Lines        9548     9548           
  Branches      539      539           
=======================================
  Hits         7451     7451           
  Misses       1906     1906           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brettedw brettedw requested review from dgboss and conbrad March 19, 2025 17:13
@@ -49,7 +49,7 @@ async def main(for_dates: list[date], run_type: RunType):
run_param = await get_most_recent_run_parameters(session, run_type, for_date)
if run_param:
run_datetime = run_param[0].run_datetime
await process_stats.process_stats(run_type, run_datetime, run_datetime.date(), for_date)
await process_stats.process_stats(run_type, run_datetime, for_date)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleans up the interface, thanks!

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brettedw brettedw closed this Mar 19, 2025
@brettedw brettedw reopened this Mar 19, 2025
@brettedw brettedw temporarily deployed to production March 20, 2025 15:26 Inactive
@brettedw brettedw merged commit 27e8d33 into main Mar 20, 2025
28 checks passed
@brettedw brettedw deleted the task/hfi-processing-dates branch March 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants