Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guild #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Guild #36

wants to merge 3 commits into from

Conversation

Hawthorne001
Copy link

@Hawthorne001 Hawthorne001 commented Aug 29, 2024

Description

  • ...
  • ...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual Testing
    • Sample results/txn hashes/screenshots:
      • ...
      • ...
  • Automated Testing
    • ...

Test Configuration:

  • ...

Steps to reproduce

  • ...

Using New Sample Function

Signature: async DepositManager.getTransferFee(request: GetTransferFeeRequest) => Promise<GetTransferFeeResponse>

Sample Request:

  const request: GetTransferFeeRequest = {
      fromChainId: -123,
      toChainId: -456,
      tokenAddress: "0xabc",
      amount: "1234567890",
  };

  const response = await depositManager.getTransferFee(request);

Sample Response:

{
  code: 200,
  message: "successfuly...",
  gasFee: "0",
  transferFee: "0.36006636000000003",
  transferFeePercentage: "0.12002212",
  reward: "0",
  netTransferFee: "0.36006636000000003",
  amountToGet: "299.63993364"
}

Automated Tests Added/Updated

  • E2E Tests
    • ...
  • Unit Tests
    • ...

Coverage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Author

@Hawthorne001 Hawthorne001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant