p2p: support new msg broadcast features; #3043
Open
+113
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2p: support new msg broadcast features; p2p: add more logs;
buddh0
reviewed
Apr 23, 2025
| @@ -764,6 +778,13 @@ func (h *handler) BroadcastBlock(block *types.Block, propagate bool) { | |||
| transfer = peers[:] | |||
| } else { | |||
| transfer = peers[:int(math.Sqrt(float64(len(peers))))] | |||
| // add more direct broadcast peers | |||
There was a problem hiding this comment.
maybe too much peers to broadcast...
There was a problem hiding this comment.
It's ok, we use the flood broadcast mechanism for validator network, the maximum number of nodes that can be broadcast simultaneously is 200, which depends on MaxNodeIDs*NumOfValidator.
By the way, if the remote know the block, it won't broadcast too.
|
need a better var name than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to implement the msg broadcast mechanism of bnb-chain/BEPs#563.
For Message Propagation
Some connection features will be enabled between validators to optimize network congestion and reduce message latency.
It will make a more stable network between validators. It also allows adding more normal nodes in
DirectBroadcastList.Example
You should set the config as below:
Changes
Notable changes: