Issue-374 Add unit tests and improve solution #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the linked GitHub issue from the previous version of the badge: badges/shields#8671 In summary, this badge was changed in a breaking fashion such that the badge was just linking to the github issue rather than showing the data. Updating the url resolves this. I also updated to using py4j as the GitHub user.
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
53efb99 to
ba0caad
Compare
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
5e91317 to
0471bbb
Compare
This PR proposes to upgrade Sphinx version to fix up the documentation build. It fails as below: ``` Run cd py4j-web && make clean html && cd .. rm -rf _build/* sphinx-build -b html -d _build/doctrees "-W" . _build/html Running Sphinx v4.5.0 Sphinx version error: The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version. make: *** [Makefile:33: html] Error 2 mv: cannot stat 'py4j-web/_build/html': No such file or directory Error: Process completed with exit code 1. ``` for now, see also https://github.com/py4j/py4j/actions/runs/8228399854/job/22497777089?pr=519
https://endoflife.date/python Python versions up to 3.7 are all EOL. This PR proposes to drop all of EOL versions, and updates its CI.
…s with setting timeout (py4j#536)
This PR adds the official support of Python 3.12.
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
3 times, most recently
from
eb083b4 to
0e2baca
Compare
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
6051868 to
a642fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I don't want to steal your solution, so I would like to merge these changes into your branch.
Could you take a look?
@srilman