-
Notifications
You must be signed in to change notification settings - Fork 940
Cluster: Add --status-only
flag to lxc cluster restore
command
#15267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cluster: Add --status-only
flag to lxc cluster restore
command
#15267
Conversation
3200c79
to
00ceedc
Compare
00ceedc
to
e364448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, there's a few code cleanups and optimisations we can do thought whilst we looking at this code.
also needs a rebase please |
--member-only
flag to lxc cluster restore
command--member-only
flag to lxc cluster restore
command
041a275
to
a7098b3
Compare
a7098b3
to
21526ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyedit suggestion + suggestion about flag naming.
cf47c17
to
f7fa9ef
Compare
--member-only
flag to lxc cluster restore
command--status-only
flag to lxc cluster restore
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing member-only
to status-only
.
I am still seeing multiple places where member_only
is used, seems like those should also be updated to status_only
.
f7fa9ef
to
3603495
Compare
should be fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a couple more instances of memberOnly
3603495
to
36253c9
Compare
please rebase |
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
…nly if `--status-only` is false Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
36253c9
to
cfbb9e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ty (for docs/naming anyway - I see there are test failures)
tests look flaky |
hmm yes. I'm trying to understand why. |
JIRA ticket: https://warthogs.atlassian.net/browse/LXD-2602?atlOrigin=eyJpIjoiOGUwYzQ5ODJmZjNkNGEyMzk4MTlmN2ZhZWY1YWM5MzciLCJwIjoiaiJ9
This adds a
--status-only
flag to thelxc cluster restore
command, which allows a cluster member to be restored to the online state without affecting any instances.Problem
When a node is evacuated and then restored using
lxc cluster restore
:We may want to restore just the node's status to online without affecting the current state and location of instances.
Solution
Added a new
--status-only
flag to thelxc cluster restore
command that:API extension
Added
clustering_restore_member_only
API extensionTesting
--status-only
flag