Improved writing to files by implementing the class FastOStream #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature_anton
This reverts commit 00194bb.
It's slower to convert non-strings to strings manually, than just handing them over to FastOStream and let it do the rest.
# Conflicts: # src/openms/source/ANALYSIS/OPENSWATH/OpenSwathTSVWriter.cpp
akriese
changed the title
Revert parts of "some more cases covered in FastOStream"
Extra overload needed for Win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As writing to a file takes up some time in almost all TOPP-Tools, we thought, that this could be improved by avoiding the construction and destruction of sentries, as normally there is only one thread writing output to a file. For that, we built a new class FastOStream, that references a given std::ostream and writes to it using the 'os.rdbuf()->sputn(s, n)' method. Overloads for the operator<<() are different string-like types, arithmetic types (using boost::karma for conversions), DataValue and vector.
We implemented the class in multiple files (all judged to be relevant by @cbielow) and replaced the old ostreams.
Tests / testfiles had to be changed as boost::karma's conversions are different compared to the std::ios_base's. (as discussed in #4684 and #4627)
Note that this class has undefined behaviour if accessed by multiple threads at once.
The speedup of storing files lies at up to 15%, depending on the operating system.