Skip to content

Suggesting more universal column spacing for song listings #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rkratky
Copy link

@rkratky rkratky commented May 10, 2020

I found that ui_weights = (2, 1, 1, 0.2, 0.2) provide more universally usable column widths for song lists in the Search and Queue panels.

Song titles tend to be forced to wrap more often with the orig. settings. Artist and album names are usually shorter.

Ideally this would be made configurable.

@rkratky
Copy link
Author

rkratky commented May 12, 2020

I added a second commit/suggestion: to use ui_weights also for album listings.

@cfangmeier
Copy link
Owner

Sorry it took so long to respond to this. The reasoning for the original weights was actually me listening to the LOTR soundtrack at work which has quite long album titles (eg "Lord of the Rings: The Two Towers (Original Motion Picture Soundtrack)"). I think as long as there is wrapping, there will be this issue.

I can think of a couple things to try out:

  1. Allow for overriding the ui_weights in the config file.
  2. Truncate overlong fields, and indicate it with ellipses.

Both options have their pros and cons.

@rkratky
Copy link
Author

rkratky commented Jun 5, 2020

Allow for overriding the ui_weights in the config file.
Truncate overlong fields, and indicate it with ellipses.

I think it would be great to allow both of these options: The default would be wrapping with the orig. ui_weights. And then it would be possible to turn on truncating and configure column weights.

Btw., thanks for a great tool. I've been using it exclusively ever since I discovered it a couple of months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants