Add path param to Transform::transform
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the only information about a node available to `Transformer` implementations was its type. This made contextual transformations hard to implement. For example, transforming an `Expr` in a projection differently to an `Expr` in an `ORDER BY` clause. The context parameter enables context-sensitive transformations of AST nodes by including the path from the root of the AST to the parent of `original_node`.
freshtonic
force-pushed
the
refactor/transformer-context
branch
from
7b99789 to
cdf2e7c
Compare
freshtonic
force-pushed
the
refactor/transformer-context
branch
from
01235fb to
eb9174a
Compare
freshtonic
force-pushed
the
refactor/transformer-context
branch
7 times, most recently
from
b066999 to
6fe9f8c
Compare
`AsNodeKey` is the *only* way to contruct a `NodeKey` in a consuming crate now. `Semantic` was poorly thought out. It existed to prevent a `NodeKey` from being created from a `Box<N: Visitable>` (because annotations should go on the inner type). It was really easy to forget to deref a `Box<N: Visitable>` when creating a `NodeKey` - annotations end up on the Box instead of the N. Which is annoying when you're trying to debug why annotations seem to be missing later on. So the impl of `AsNodeKey` for `Box<N: AsNodeKey>` dereferences to the contained type. AsNodeKey is implemented for `Option<N: 'static>` - returning a `NodeKey` proxying the `Option` itself - because it might be `None`.
freshtonic
force-pushed
the
refactor/transformer-context
branch
from
6fe9f8c to
e16406f
Compare
Renamed `Context` -> `NodePath`. Dropped `current_node` argument from `Transform::transform` and put `node_path` before `new_node`. It's nicer when contextual arguments come first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the only information about a node available to
Transformerimplementations was its type.This made contextual transformations hard to implement. For example, transforming an
Exprin a projection differently to anExprin anORDER BYclause.The path parameter enables context-sensitive transformations of AST nodes by including the path from the root of the AST to the parent of the
original_node.