Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-core] adds eslint-plugin-jsx-a11y rule #3894

Merged
merged 6 commits into from
Apr 8, 2025
Merged

[ui-core] adds eslint-plugin-jsx-a11y rule #3894

merged 6 commits into from
Apr 8, 2025

Conversation

bjornalm
Copy link
Collaborator

What changes were proposed in this pull request?

Improve accessibility by adding eslint-plugin-jsx-a11y to the linter

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from e236359 to 96554b0 Compare January 7, 2025 11:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 22, 2025
@github-actions github-actions bot closed this Mar 4, 2025
@bjornalm bjornalm reopened this Mar 19, 2025
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from 96554b0 to 09fa4b1 Compare March 19, 2025 08:11
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL535932625551% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1105 106 💤 0 ❌ 0 🔥 5m 55s ⏱️

@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from 09fa4b1 to 5a8c041 Compare March 19, 2025 10:30
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@ramprasadagarwal ramprasadagarwal force-pushed the bjorn--add-accessibility-linting branch from b624003 to 3eb5799 Compare March 26, 2025 16:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

✅ Test files were modified. Ensure that the tests cover all relevant changes

@ramprasadagarwal ramprasadagarwal removed their request for review April 2, 2025 12:02
@bjornalm bjornalm requested review from JohanAhlen and tabraiz12 April 2, 2025 12:08
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) April 2, 2025 12:10
@ramprasadagarwal ramprasadagarwal changed the title add eslint-plugin-jsx-a11y [ui-core] adds eslint-plugin-jsx-a11y rule Apr 2, 2025
@bjornalm bjornalm disabled auto-merge April 2, 2025 12:11
@bjornalm bjornalm marked this pull request as draft April 2, 2025 12:12
@bjornalm bjornalm assigned tabraiz12 and unassigned tabraiz12 Apr 4, 2025
@bjornalm bjornalm requested a review from tabraiz12 April 4, 2025 12:20
@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from 7018a57 to 087403e Compare April 4, 2025 12:22
@bjornalm bjornalm marked this pull request as ready for review April 7, 2025 13:40
@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from 087403e to 4fc491d Compare April 7, 2025 13:40
@bjornalm bjornalm enabled auto-merge (rebase) April 7, 2025 13:40
JohanAhlen
JohanAhlen approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjornalm bjornalm force-pushed the bjorn--add-accessibility-linting branch from 4fc491d to 31e5087 Compare April 8, 2025 08:10
@bjornalm bjornalm merged commit 39e2842 into master Apr 8, 2025
7 of 8 checks passed
@bjornalm bjornalm deleted the bjorn--add-accessibility-linting branch April 8, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@ramprasadagarwal ramprasadagarwal ramprasadagarwal approved these changes

@ssinha43 ssinha43 ssinha43 approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@ananya-agarwal ananya-agarwal Awaiting requested review from ananya-agarwal

@nidhibhatg nidhibhatg Awaiting requested review from nidhibhatg

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjornalm @JohanAhlen @ramprasadagarwal @ssinha43 @tabraiz12