-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui-Quick Start] Convert the Quick Start page within administrator server in ReactJS #4025
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! I've added some quick review comments.
desktop/core/src/desktop/js/apps/about/components/ko.connectorsConfig.js
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Overview/OverviewTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Overview/OverviewTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Overview/OverviewTab.tsx
Outdated
Show resolved
Hide resolved
|
1 similar comment
|
167dbf1
to
264d42c
Compare
|
1 similar comment
|
Backend Code Coverage Report •
Pytest Report
|
3672760
to
d545a19
Compare
|
1 similar comment
|
|
73c5e6d
to
8e120f0
Compare
|
1 similar comment
|
1b22cf5
to
9e2ed1c
Compare
|
1 similar comment
|
desktop/core/src/desktop/js/apps/admin/Overview/ConfigStatus.tsx
Outdated
Show resolved
Hide resolved
7fe4ff6
to
c8fa0f1
Compare
const [collectUsage, setCollectUsage] = useState<boolean>(false); | ||
const { t } = i18nReact.useTranslation(); | ||
|
||
const saveCollectUsagePreference = async (collectUsage: boolean) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harshg999 We don't have a get api for collectUsage? currently even in old pages on refresh checkbox state is not saved? Do we have any get api's we can reuse?
desktop/core/src/desktop/js/apps/admin/Overview/ConfigStatus.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Overview/OverviewTab.tsx
Outdated
Show resolved
Hide resolved
WIP
efc1c7b
to
625ce68
Compare
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsHeader.tsx
Outdated
Show resolved
Hide resolved
WIP WIP WIP
What changes were proposed in this pull request?
Update the Quick Start page to use React and align it with the Cloudera Design Language. Quick Start has been renamed as Overview at some places.
How was this patch tested?
Unit tests, manual testing
Updated pictures of the Quick Start page:
Please review Hue Contributing Guide before opening a pull request.