Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-Quick Start] Convert the Quick Start page within administrator server in ReactJS #4025

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ananya-agarwal
Copy link
Collaborator

@ananya-agarwal ananya-agarwal commented Mar 4, 2025

What changes were proposed in this pull request?

Update the Quick Start page to use React and align it with the Cloudera Design Language. Quick Start has been renamed as Overview at some places.

How was this patch tested?

Unit tests, manual testing

Updated pictures of the Quick Start page:

Screenshot 2025-04-01 at 4 06 05 PM Screenshot 2025-03-24 at 1 40 20 PM Screenshot 2025-03-24 at 1 42 23 PM Screenshot 2025-03-24 at 1 43 50 PM

Please review Hue Contributing Guide before opening a pull request.

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! I've added some quick review comments.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@ananya-agarwal ananya-agarwal force-pushed the Overview branch 3 times, most recently from 7fe4ff6 to c8fa0f1 Compare April 7, 2025 06:58
const [collectUsage, setCollectUsage] = useState<boolean>(false);
const { t } = i18nReact.useTranslation();

const saveCollectUsagePreference = async (collectUsage: boolean) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harshg999 We don't have a get api for collectUsage? currently even in old pages on refresh checkbox state is not saved? Do we have any get api's we can reuse?

@ananya-agarwal ananya-agarwal force-pushed the Overview branch 3 times, most recently from efc1c7b to 625ce68 Compare April 9, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants