Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue SAML logout not Post CDP logout URL #4038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tabraiz12
Copy link
Collaborator

What changes were proposed in this pull request?

  • this seems an existing issue when logout happens from saml, there seems to be user session not being present, so it ends up with internal server errror
hue File "/opt/hive/build/env/lib/python3.9/site-packages/django/contrib/auth/models.py", line 420, in __int__
hue raise TypeError('Cannot cast AnonymousUser to int. Are you trying to use it in place of User?')
hue TypeError: Cannot cast AnonymousUser to int. Are you trying to use it in place of User?

I have made small change to check if user exists before performing that action.

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
desktop/core/src/desktop/auth
   views.py2076867%20–21, 59–63, 65, 67–72, 74, 89, 106–107, 115–116, 144–145, 148, 153, 157–158, 161–162, 188, 191–192, 199, 205–206, 245, 253–258, 261, 272, 276, 289, 291–293, 298–299, 301, 303, 305, 310–312, 314–316, 318, 320–321, 323–324, 329–332
TOTAL533172613850% 

Pytest Report

Tests Skipped Failures Errors Time
1088 107 💤 0 ❌ 0 🔥 4m 48s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant