remove lifetime from the Signer struct #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is rather difficult to reuse the Signer in a dynamic application with the lifetime present in the struct. This commit removes the lifetime to make it easier to cache and reuse. The logger has also been removed from the API for the signer. It was used only in one place to log a single debug line, and it is a bit of an imposition on the embedding application to require the use of the `slog` crate just for that, and its removal helps with the goal of removing lifetimes from the struct as well. Some builder methods have been made a little more ergonomic by accepting values that are convertible to String rather than requiring str references. Since this commit changes the API signature, it also bumps the version from 0.2 to 0.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you'll go for this, but I'm hoping to avoid maintaining a fork!
It is rather difficult to reuse the
Signerin a dynamic application with the lifetime present in the struct.This commit removes the lifetime to make it easier to cache and reuse.
The logger has also been removed from the API for the signer. It was used only in one place to log a single debug line, and it is a bit of an imposition on the embedding application to require the use of the
slogcrate just for that, and its removal helps with the goal of removing lifetimes from the struct as well.Some builder methods have been made a little more ergonomic by accepting values that are convertible to String rather than requiring str references.
Since this commit changes the API signature, it also bumps the version from 0.2 to 0.3.