-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CMAKE min version #557
base: master
Are you sure you want to change the base?
Conversation
cmake 3.0 is deprecated. You need to upgrade to 3.10 (minimum non-deprecated version)
Thank you for the PR. I was not aware about the upcoming deprecation in CMake version 4.0. According to CMake documentation a command |
https://cmake.org/cmake/help/latest/release/3.31.html Deprecated and Removed Features |
The CMake release notes link and the |
The link you cite states that cmake versions < 3.5 have been removed. In order to support old and new version of cmake I propose to update to version 3.5 Thank you for your availability to review |
Thanks for your reply. It does not matter what minimum version your choose. Only the maximum version matters, as it says "I am aware of all the policies and settings up to this version". It determines the maximum supported version without needing changes to the CMakeLists.txt. So you could keep the minimum version as is to enable maximum portability. As of Boost 1.83 only supporting CMake version 3.5: Coin suppports Boost since 1.35 and only requires the header only part of Boost. So that's not a problem. |
I would like to point out that when github compiling "C.I." on ubuntu, it fails because of the incompatibility with cmake 4. CMake Error at CMakeLists.txt:1 (cmake_minimum_required):Compatibility with CMake < 3.5 has been removed from CMake.https://github.com/coin3d/coin/actions/runs/14204262087/job/39798140761 One of these decisions can be made to solve the problem:
|
The failing calls to CMake tell three ways how to solve the issue.
And instead of raising the minimum required version I prefer the |
cmake 3.0 is deprecated.
You need to upgrade to 3.5 (minimum supported version in cmake 4.0)