[16.0][MIG] pos_customer_wallet #300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
changed the title
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
06ace62 to
1109db1
Compare
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
1109db1 to
afb08db
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 16.0 #300 +/- ##
==========================================
- Coverage 97.73% 94.52% -3.22%
==========================================
Files 12 26 +14
Lines 221 347 +126
Branches 30 39 +9
==========================================
+ Hits 216 328 +112
- Misses 1 15 +14
Partials 4 4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
….config Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…t payment method Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…stead of settings Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…ines This does not yet live-update in the POS. The window needs to be reloaded to see the updated balance. Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
… balance Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…ner._invoice_total algorithm Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…r account is set instead Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…ly tree Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…thout perms Previously there was a permission error on trying to read the `account.bank.statement.line` model. Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
2 times, most recently
from
228bd28 to
7f85b83
Compare
base_suspend_security's functionality is wrapped into Odoo's sudo by default
This change was also done in account_customer_wallet. It simplifies things. This change is necessary for the 16.0 migration, but is not included in its commit for clarity's sake. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…t computation The pos session does not create these anymore. It creates pos.payment records instead. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…ssion Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
7f85b83 to
dcf77e8
Compare
|
I have to review this one ! thanks for the ping ! |
|
@carmenbianca à combien d'heures estimes-tu la finalisation du portage ? |
…wallet products Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
dcf77e8 to
2038376
Compare
|
@legalsylvain i added one important test for taxation. this should technically never be needed, but it's good to know that everything is correctly implemented. ping for review :) edit: of course it breaks in CI but not locally... |
ahah ! let me know when it's green. Thanks ! |
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
2038376 to
ae86302
Compare
|
@carmenbianca : I'm not sure. Are you waiting for my review, or Do I have to wait the CI is green ? thanks ! |
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
2289271 to
ab6e825
Compare
This assertion is different between the CI environment (4 elements) and local tests (3 elements). This discrepancy was introduced after the previous commit. Exactly why it is different, I do not know, but the assertion is not important enough to waste hours debugging. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
16.0-mig-pos_customer_wallet
branch
from
ab6e825 to
a77446d
Compare
|
hi @legalsylvain ! if you have time, this still needs some reviewing. |
Work in progress ! I just finished a functional review. All is OK until session is closed. At this time, the balance of the customer become wrong. Use case :
What do you think ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Odoo task (if applicable)
https://gestion.coopiteasy.be/web#id=10799&action=475&active_id=492&model=project.task&view_type=form&menu_id=536
Checklist before approval