Skip to content

docs: note block in execute the DAG of QuickStart #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Lewiscowles1986
Copy link
Contributor

@Lewiscowles1986 Lewiscowles1986 commented Feb 24, 2025

See #841

Just a note-block for now.

I noticed the other note: was not a note block, but managed to find an example in rest.rst of how this project was setup.

When testing I did use python 3.11.9 instead of 3.7.16 (which I think was old in 2018 😄 )

I can add changing the python version to this, but it might be better to have in it's own PR and issue so others can discuss.

@Lewiscowles1986
Copy link
Contributor Author

Apologies, found a unexpected silent failure to highlight docker-compose.yml

Screenshot 2025-02-24 at 19-45-45 Quick Start Guide — Dagu documentation

@Lewiscowles1986 Lewiscowles1986 force-pushed the docs/add-notes-on-docker-compose-in-examples branch from f528578 to fa0fc2b Compare February 24, 2025 20:37
Copy link
Collaborator

@yottahmd yottahmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I had no idea the note block existed. Looks awesome! Yeah, let’s update the Python version in a separate PR!

@yottahmd yottahmd merged commit 98af2b7 into dagu-org:main Feb 25, 2025
4 checks passed
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.05%. Comparing base (be37a0b) to head (fa0fc2b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   56.02%   56.05%   +0.03%     
==========================================
  Files          75       75              
  Lines        8188     8188              
==========================================
+ Hits         4587     4590       +3     
+ Misses       3215     3213       -2     
+ Partials      386      385       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be37a0b...fa0fc2b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants