-
Notifications
You must be signed in to change notification settings - Fork 0
[cli] feat: export GTFS data to database & for ingesting into directions/routing API #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
danshilm
wants to merge
13
commits into
develop
Choose a base branch
from
feat/cli/geojson-to-gtfs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6df6dd8
to
ba95408
Compare
ba95408
to
dd288dd
Compare
5fd1698
to
6c0aa43
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6c0aa43
to
d3c892c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I wanted to export the data from OSM to GTFS files and then use that to feed into the routing API. But that would require also augmenting the OSM data before I can use it in the mobile app. That also leads us to have the issue where we are essentially at the mercy of the data on OSM. Bad idea ❌
Now, the way I decided to do it is to export the data from OSM into the database in a structure that's as close to the GTFS format as possible (having it be exact would be great). Use that data to generate the GTFS files, and use those GTFS files to generate the geojson (with gtfs-to-geojson) for use in the mobile app and to feed into the routing API. The data in the database can be easily verified and will serve as the source of truth. This also allows for users to easily edit the data if necessary. And those changes can then be selectively propagated to OSM once verified (we don't want erroneous data to end up on OSM neither).
I don't like Firestore for this. It was a bad decision. Sure, out-of-the box offline support is hella nice, but moulding structured data into a NoSQL database is just asking for troubles. Sigh.. 😮💨 I will migrate the data to a proper SQL database (long live Supabase 🎉), but for now, the most important feature of the mobile app needs to be functional first.
GTFS files to add (reference):