Skip to content

Handle Elegant ; line ending #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 9, 2025
Merged

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Mar 21, 2025

Description

Just adds stripping of ; from elegant line endings and modifies the test to reflect it.

Motivation and Context

The CLARA/FEBE elegant lattice has these line endings and it otherwise causes parsing errors.
Closes #383

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@amylizzle amylizzle marked this pull request as ready for review March 21, 2025 17:13
@jank324 jank324 added bug Something isn't working enhancement New feature or request labels Apr 8, 2025
@jank324 jank324 removed the enhancement New feature or request label Apr 8, 2025
@jank324 jank324 merged commit e01cd1f into desy-ml:master Apr 9, 2025
8 checks passed
@amylizzle amylizzle deleted the elegant_line_ending branch April 9, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elegant parsing chokes on ; line endings
2 participants