perf: EXC-1998: Refactor heap benchmarks #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berestovskyy
force-pushed
the
andriy/exc-1998-refactor-heap-benchmarks
branch
from
9324d20 to
70bf249
Compare
Base automatically changed from
andriy/exc-1998-more-heap-benchmark-fixes
to
master
March 27, 2025 16:09
Using a large `heap.wat` file is error-prone and make it difficult to add new cases. This PR generates Wasm code snippets on the fly. Also, it adds a new benchmark dimension for newly allocated memory.
berestovskyy
force-pushed
the
andriy/exc-1998-refactor-heap-benchmarks
branch
from
70bf249 to
2344569
Compare
dsarlis
reviewed
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a large
heap.watfile is error-prone and make it difficult to add new cases.This PR generates Wasm code snippets on the fly.
Also, it adds a new benchmark dimension for newly allocated memory.