Dark theme and icon to toggle theme #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

eoto88 wants to merge 6 commits into digininja:master from eoto88:dark-theme

Contributor

eoto88 commented Apr 2, 2025

Dark theme perfect for late night hacking. Icon is from Material Design : https://pictogrammers.com/library/mdi/

ture2307 added 2 commits

April 1, 2025 20:07


          Add dark theme and button to toggle theme

d55c40f


          Adjustments for dark theme

804b3f9

Owner

digininja commented Apr 2, 2025

That seems to work, but could you resubmit it without the docker changes so that it is a standalone change. Nothing will go wrong with it, but just in case, it lets me roll back this one thing without affecting the other.

ture2307 and others added 3 commits

April 2, 2025 09:29


          Revert "Uncomment 2 lines to serve local source"

4e686a6

This reverts commit 87867d3.


          Revert "Adjustment to the documentation"

bea0885

This reverts commit f55308f.


          Merge branch 'master' into dark-theme

cc26323

github-advanced-security bot found potential problems

View reviewed changes

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo.

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo.

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\ncall to echo.

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\ncall to echo.

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\ncall to echo.

dvwa/includes/dvwaPage.inc.php

@@ @@ -189,6 +189,14 @@ @@
               }
+              function dvwaThemeGet() {
+              	if (isset($_COOKIE['theme'])) {
+              		return $_COOKIE[ 'theme' ];

Check failure

Code scanning / PHP Security Analysis

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error

Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\ncall to echo.

Contributor Author

eoto88 commented Apr 2, 2025

I reverted 3 commits but I'm not sure if it will just remove those commits from master if merged. Let me know if I should start a new branch from master, create a new PR and close this PR.


          Dark theme and icon to toggle theme

96431dd

eoto88 marked this pull request as draft

April 2, 2025 13:58

eoto88 closed this

eoto88 deleted the dark-theme branch

April 2, 2025 14:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet