Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few clippy warnings.
doc(cfg(..)
Currently, https://docs.rs/nalgebra/latest/nalgebra/base/par_iter/struct.ParColumnIter.html doesn't warn that the feature
rayon
should be activated, well it's written in comments, but it should be covered by the line:#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
But it is not, because
doc_cfg
is a feature, so it should be written:#[cfg_attr(feature = "doc_cfg", doc(cfg(feature = "rayon")))]
.BUT now rust requires all features to be listed in
Cargo.toml
, or it will complain about "unexpected cfg", I think it makes little sense to go through an intermediate feature, which would add noise to existing feature list, so I just replaced it bydocsrs
compile flag, which works as showcased:Note