Add logic to parse BUILDKIT_SYNTAX option for --build-arg #3148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@c95fe14...da05d55) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: 2.2.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
notable changes - fixes CVE-2025-22868 - oauth2.go: use a more straightforward return value - oauth2: Deep copy context client in NewClient - jws: improve fix for CVE-2025-22868 full diff: golang/oauth2@v0.23.0...v0.29.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
full diff: containerd/containerd@v2.0.4...v2.0.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
diff: moby/moby@v28.1.0...v28.1.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
no changes in vendored code diff: docker/cli@v28.1.0...v28.1.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
added logic to handle BUILDKIT_SYNTAX option with --build-arg I am making this change because the docs suggest that the BUILDKIT_SYNTAX option is equivalent to the #syntax directive one could use in a dockerfile, but omitting the directive and keeping BUILDKIT_SYNTAX currently does not lead to a succesful build. Resolves: docker#3077 Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a build description using a custom frontend to a BuildKit instance with dockerfile.v0 frontend disabled does not lead to a successful build, even though using a custom dockerfile syntax should use the gateway.v0 frontend in the BuildKit instance.
Though the change I added fixes the bug described in #3077, I discovered a similar bug while using a BuildKit instance with dockervile.v0 disabled. If you use the #syntax directive in the custom dockerfile without the BUIDKIT_SYNTAX option, the build will fail with the same error as described in the aforementioned issue.
If any maintainer wants me to work on this newly discovered bug I would be happy to do so.
Anyway, this is my first pull request so advice and feedback are greatly appreciated, thank you!