-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 10 P3 - SDK Notes #9822
.NET 10 P3 - SDK Notes #9822
Conversation
Doc list for me: CLI
ContainersTest |
For me I'd like to add
|
What do you think of this? |
nit: a native experience for Microsoft.Testing.Platform |
@DamianEdwards do you want to do a blurb for |
I don't want to announce until P4+ as it's missing some key features in P3. |
thanks - noted that on my list. |
First draft up - @nohwnd want to spot-check the test section? @dsplaisted for SDK-related words as well. |
## Feature | ||
```toml | ||
[dotnet.test.runner] | ||
name = "Microsoft.Testing.Platform" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Youssef1313 / @mariam-abdulla did you manage to merge the change that understands the new format without the :
? I saw remarks about the change being in preview4 in multiple places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the :
-based impl work? I'm concerned with putting something in the p3 relnotes and then changing it in p4 - folks often just google and copy-paste.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:
violates TOML and is going to P3. Unfortunately, we already documented it and it's shipping in P3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Youssef1313 / @mariam-abdulla did you manage to merge the change that understands the new format without the
:
? I saw remarks about the change being in preview4 in multiple places.
Yes the change was merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather just not talk about the non-compliant feature in p3 if a fix and future-forward version is coming in a month. Similar logic to what Damian was saying with regards to dotnet-run singlefile. You get one chance to make a first impression - it should be correct and complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baronfel So you mean drop it from release notes?
We have had it documented in dotnet/docs
repo though and have seen few users playing with it already on Preview 2 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the change was merged.
I meant merged in code that will be released in preview3.
I assume "Microsoft.Testing.Platform" would NOT work with preview3 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted to the working p3 form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Microsoft.Testing.Platform" should work with preview 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: actually fixed the things - Microsoft.Testing.Platform
and dotnet.test:runner
for p3
Please ping me when ready to merge |
@jamesmontemagno go ahead! |
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
No description provided.