Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 10 P3 - SDK Notes #9822

Merged
merged 6 commits into from
Apr 7, 2025
Merged

.NET 10 P3 - SDK Notes #9822

merged 6 commits into from
Apr 7, 2025

Conversation

jamesmontemagno
Copy link
Member

No description provided.

@baronfel
Copy link
Member

baronfel commented Mar 27, 2025

@Youssef1313
Copy link
Member

Youssef1313 commented Mar 27, 2025

For me I'd like to add dotnet test support for Microsoft.Testing.Platform under CLI. Conceptual docs. A small brief like:

## Microsoft.Testing.Platform (MTP) as first-citizen in `dotnet test` CLI

In .NET 10 Preview 3, `dotnet test` now has a native experience towards [Microsoft.Testing.Platform](https://aka.ms/mtp-overview), which you can opt-in by using `dotnet.config` file as follows:

```toml
[dotnet.test:runner]
name = "Microsoft.Testing.Platform"
```

For more information, see [Testing with `dotnet test`](https://learn.microsoft.com/dotnet/core/testing/unit-testing-with-dotnet-test), which explains how Microsoft.Testing.Platform used to work with `dotnet test` in .NET 9 and earlier, and why a new `dotnet test` experience is needed.

cc @nohwnd @mariam-abdulla

@mariam-abdulla
Copy link
Member

mariam-abdulla commented Mar 27, 2025

## Microsoft.Testing.Platform (MTP) as a First-Class Citizen in `dotnet test` CLI

Starting with .NET 10 Preview 3, `dotnet test` now offers a native experience towards [Microsoft.Testing.Platform](https://aka.ms/mtp-overview). You can enable this feature by adding the following configuration to your dotnet.config file:

 ```toml
 [dotnet.test:runner]
 name = "Microsoft.Testing.Platform"

For more details, refer to [Testing with `dotnet test`](https://learn.microsoft.com/dotnet/core/testing/unit-testing-with-dotnet-test), which explains how Microsoft.Testing.Platform was integrated with `dotnet test` in .NET 9 and earlier versions, and the reasons behind the new `dotnet test` experience.

What do you think of this?
@Youssef1313 @nohwnd @MarcoRossignoli

@nohwnd
Copy link
Member

nohwnd commented Mar 27, 2025

a native experience towards

nit: a native experience for Microsoft.Testing.Platform

@baronfel baronfel self-assigned this Mar 30, 2025
@baronfel
Copy link
Member

@DamianEdwards do you want to do a blurb for dotnet run foo.cs, or would you like me to do that when I tackle my own blurbs?

@DamianEdwards
Copy link
Member

I don't want to announce until P4+ as it's missing some key features in P3.

@baronfel
Copy link
Member

thanks - noted that on my list.

@baronfel
Copy link
Member

baronfel commented Apr 2, 2025

First draft up - @nohwnd want to spot-check the test section? @dsplaisted for SDK-related words as well.

## Feature
```toml
[dotnet.test.runner]
name = "Microsoft.Testing.Platform"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youssef1313 / @mariam-abdulla did you manage to merge the change that understands the new format without the :? I saw remarks about the change being in preview4 in multiple places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the :-based impl work? I'm concerned with putting something in the p3 relnotes and then changing it in p4 - folks often just google and copy-paste.

Copy link
Member

@Youssef1313 Youssef1313 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: violates TOML and is going to P3. Unfortunately, we already documented it and it's shipping in P3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youssef1313 / @mariam-abdulla did you manage to merge the change that understands the new format without the :? I saw remarks about the change being in preview4 in multiple places.

Yes the change was merged.

Copy link
Member

@baronfel baronfel Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather just not talk about the non-compliant feature in p3 if a fix and future-forward version is coming in a month. Similar logic to what Damian was saying with regards to dotnet-run singlefile. You get one chance to make a first impression - it should be correct and complete.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baronfel So you mean drop it from release notes?

We have had it documented in dotnet/docs repo though and have seen few users playing with it already on Preview 2 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the change was merged.

I meant merged in code that will be released in preview3.

I assume "Microsoft.Testing.Platform" would NOT work with preview3 right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to the working p3 form.

Copy link
Member

@Youssef1313 Youssef1313 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: actually fixed the things - Microsoft.Testing.Platform and dotnet.test:runner for p3

@jamesmontemagno
Copy link
Member Author

Please ping me when ready to merge

@baronfel
Copy link
Member

baronfel commented Apr 7, 2025

@jamesmontemagno go ahead!

jamesmontemagno and others added 2 commits April 7, 2025 13:33
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@jamesmontemagno jamesmontemagno merged commit 91fd38a into dotnet10-p3 Apr 7, 2025
2 checks passed
@jamesmontemagno jamesmontemagno deleted the dotnet10-sdk branch April 7, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants