Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Basic Sleep App issue #53 #57

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

PR: Basic Sleep App issue #53 #57

wants to merge 24 commits into from

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Mar 19, 2022 •
edited
Loading

Checklist in: #53

The main file you need to read-through is: tutorial.md

nelsonic added 23 commits December 8, 2021 23:39
@nelsonic
mix phx.new app #53
fe1ca06
@nelsonic
add outline of desired functionality in "How?" section for #53
60ce732
@nelsonic
[WiP] add detail to README.md for #53
dac8dcb
@nelsonic
move tutorial to its own file #53
ec90683
@nelsonic
update version of Phoenix to 1.6.6
6fb3a05
@nelsonic
add context for "App" Namespace to tutorial.md #53
4ef32da
@nelsonic
Create .github/workflows/ci.yml to run tests #53
59cf727
@nelsonic
add more detail to README.md and links in tutorial.md #53
6231fab
@nelsonic
add ExCoveralls & coveralls.json to check test coverage #53
f48898f
@nelsonic
temporarily lower coverage threshold to 40% to avoid noise while buil…
f8c7cd3 
…ding the tutorial ...
@nelsonic
3. Create app_live.ex and insert code #53
56318a2
@nelsonic
4. Create app_view.ex and add essential code #53
9001fbb
@nelsonic
5. rename page/index.html.heex to app/index.html.heex and simplify code
da04c74 
#53
@nelsonic
5. simplify templates/layout/root.html.heex to bare minimum #53
2952ed4
@nelsonic
6. Modify router.ex to point to the AppLive instead of Page #53
0280658
@nelsonic
add steps to tutorial.md #53
3468016
@nelsonic
7. Add step to tutorial.md to repair broken test #53
2b2ba87
@nelsonic
Create elixir_buildpack.config and Procfile to deploy demo to Heroku #53
30d16e2
@nelsonic
update elixir_buildpack.config and Procfile to always_rebuild=true & …
8897af8 
…mix assets.deploy #53
@nelsonic
use ssl for DB connection on Heroku #53
6129fa1
@nelsonic
use ssl for DB connection on Heroku #53
f6e1c3f
@nelsonic
Check for DYNO envar instead of HEROKU for db ssl #53
3c16d10
@nelsonic
set preferred_cli_env for mix coveralls.json task to :test #53
1636477
@nelsonic nelsonic added technical A technical issue that requires understanding of the code, infrastructure or dependencies T4h Time Estimate 4 Hours in-progress An issue or pull request that is being worked on by the assigned person labels Mar 19, 2022
@nelsonic nelsonic self-assigned this Mar 19, 2022
@nelsonic nelsonic changed the title Basic Sleep App issue #53 PR: Basic Sleep App issue #53 Mar 20, 2022
@nelsonic nelsonic mentioned this pull request Mar 22, 2022
Open
4 tasks
@nelsonic nelsonic temporarily deployed to sleep March 24, 2022 11:24 Inactive
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@3483866). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage        ?   83.33%           
=======================================
  Files           ?        4           
  Lines           ?        6           
  Branches        ?        0           
=======================================
  Hits            ?        5           
  Misses          ?        1           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3483866...ec5d89a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nelsonic nelsonic

Labels
in-progress An issue or pull request that is being worked on by the assigned person T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nelsonic