-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*Really* fix --long file decode, plus other bits #13
Open
christopherkobayashi
wants to merge
19
commits into
endlos99:master
Choose a base branch
from
christopherkobayashi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
*Really* fix --long file decode, plus other bits #13
christopherkobayashi
wants to merge
19
commits into
endlos99:master
from
christopherkobayashi:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rograms in TIFILES format without altering source. TIFILES write support is forthcoming in the next few days.
… should fix erroneous "program is corrupt" issues while decoding.
This reverts commit ce99b70.
This reverts commit d4ab1bf.
…es. This should fix erroneous "program is corrupt" issues while decoding." This reverts commit fac201d.
This reverts commit e8c3ee4.
…cause it apparently is needed. This reverts commit 300eac4.
…tifiles to tifiles_
…sue was an off-by-one error (and not accounting for TIFILES padding)
Just wanted to let you know that I'm really busy with the FRC right now. Once I have time for xdt99 your PR will be first on my list. |
No worries, I understand. Thanks for taking the time to update me.-- Chris |
…check to see if we have an invalid token instead of trying to dereference a null.
…ion map semantics so that each bit represents two contiguous sectors, with the result that a file is always a multiple of two sectors long. This is not complete; the "comparing allocated sectors to file lengths" comparison is broken for 2880-sector images, but this code commit is functional.
DSDD80T appears to work now, without regression for other formats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there was an off-by-one in the record seek logic that fouled up --long decodes.
I've also turned on stack backtrace for the parser, so that we can debug this:
... there's an invalid opcode (0xff) creeping in somewhere, and I think it's an end-of-record marker that isn't getting purged by the long-to-short routine.
Finally, I turned on autodetect for long and TIFILES format files based on first few characters of the file.