Use qualified names when @within is omitted
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only on code I wrote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for skipping
@withinby including the class name in the tag text.--- @prop QualifiedNames.prop numberThe code checks for the first dot (.), so this is legal:
--- @prop QualifiedNames.lots.of.dots numberI decided to support
@typeand@interfacetoo because it made implementation easier. This rendersDEPENDENT_TAGSempty, but I think it is good to keep for the future.I also sneaked in a bug fix for empty interfaces since I used one for the test and I like to preview tests on the website.
I think there should be some mention of this on the website, but right now inference is kind of all over the place, so maybe there could be a new heading detailing exactly what is inferred?
Closes #5