-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Romanian translations #1070
Conversation
I've simplified the expressions used, to be closer to the `en` variant.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for this PR! @victornswd and @ancaspatariu can you confirm this improvement? |
Personally, I struggled a bit with the Romanian translation for "invalid" because in Romanian "invalid" is primarily a term for people with disabilities, so while the term "incorect" used currently is not as close to the english version, I think it is clearer in it's intent. "Invalid" also means "invalid", as a lot of computer terms in Romanian are alterations of the english terms, but "incorect" is a much more generic term which, I think, makes more sense in any kind of context |
As Victor suggested, I've changed "invalid" to "incorect". |
Does the rest look all right to you @victornswd? |
Sorry it took so long to respond, i had a very hectic week. It looks good, my recommendation would be to keep "bytes" as "byți" because that is the correct form from the dictionary, also used on the romanian wikipedia and several tech articles i checked to be sure. |
I would like to leave it like this, to keep it consistent, as not all type format names have an equivalent in romanian. Even tho' "byți" is the accepted translation it's very weird and unfamiliar. |
sure, i can get the "bytes" argument, but not the "hexadecimal" one. there already is "zecimal" in the translation and i have never heard "hexadecimal" used in romanian, even though wiki has it as a fallback for "hexazecimal", but i have heard "hexazecimal" |
Is this PR ready to get merged? |
commit: |
yes, in my opinion |
I've simplified the expressions used, to be closer to the
en
variant.