Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Romanian translations #1070

Merged
merged 5 commits into from
Mar 16, 2025
Merged

Conversation

navaru
Copy link
Contributor

@navaru navaru commented Mar 5, 2025

I've simplified the expressions used, to be closer to the en variant.

I've simplified the expressions used, to be closer to the `en` variant.
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valibot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 3:43pm

@fabian-hiller
Copy link
Owner

Thank you for this PR! @victornswd and @ancaspatariu can you confirm this improvement?

@fabian-hiller fabian-hiller self-assigned this Mar 6, 2025
@fabian-hiller fabian-hiller added the enhancement New feature or request label Mar 6, 2025
@victornswd
Copy link
Contributor

Personally, I struggled a bit with the Romanian translation for "invalid" because in Romanian "invalid" is primarily a term for people with disabilities, so while the term "incorect" used currently is not as close to the english version, I think it is clearer in it's intent. "Invalid" also means "invalid", as a lot of computer terms in Romanian are alterations of the english terms, but "incorect" is a much more generic term which, I think, makes more sense in any kind of context

@navaru
Copy link
Contributor Author

navaru commented Mar 9, 2025

As Victor suggested, I've changed "invalid" to "incorect".

@fabian-hiller
Copy link
Owner

Does the rest look all right to you @victornswd?

@victornswd
Copy link
Contributor

Sorry it took so long to respond, i had a very hectic week. It looks good, my recommendation would be to keep "bytes" as "byți" because that is the correct form from the dictionary, also used on the romanian wikipedia and several tech articles i checked to be sure.
Also, "hexadecimal" should be "hexazecimal" because that is the main form of the word and is consistent with "zecimal" already used

@navaru
Copy link
Contributor Author

navaru commented Mar 14, 2025

my recommendation would be to keep "bytes" as "byți" ... Also, "hexadecimal" should be "hexazecimal" ...

I would like to leave it like this, to keep it consistent, as not all type format names have an equivalent in romanian. Even tho' "byți" is the accepted translation it's very weird and unfamiliar.

@victornswd
Copy link
Contributor

sure, i can get the "bytes" argument, but not the "hexadecimal" one. there already is "zecimal" in the translation and i have never heard "hexadecimal" used in romanian, even though wiki has it as a fallback for "hexazecimal", but i have heard "hexazecimal"

@fabian-hiller
Copy link
Owner

Is this PR ready to get merged?

Copy link

pkg-pr-new bot commented Mar 14, 2025

Open in Stackblitz

npm i https://pkg.pr.new/valibot@1070

commit: d08a2d7

@victornswd
Copy link
Contributor

Is this PR ready to get merged?

yes, in my opinion

@fabian-hiller fabian-hiller merged commit 77f3302 into fabian-hiller:main Mar 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants