[DEV-11409] Grafana Migration #4261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grafana migration
sethstoudenmier
requested changes
Feb 4, 2025
usaspending_api/download/management/commands/download_sqs_worker.py
Outdated
Show resolved
Hide resolved
…her than relying on host
sethstoudenmier
previously approved these changes
Feb 14, 2025
…edspendingtransparency/usaspending-api into dev-11409-grafana-part-2
sethstoudenmier
approved these changes
Feb 20, 2025
sethstoudenmier
assigned sethstoudenmier, aguest-kc, zachflanders-frb and loreleitrimberger and unassigned sethstoudenmier, aguest-kc, zachflanders-frb and loreleitrimberger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This ticket/PR was created to continue the Grafana Migration from DataDog. Specifically, we addressed the issue of subprocess tracing inside the bulk_downloader and further streamlined alot of the information we were capturing. Logs inside loki and traces inside tempo have also been aligned. The testing suite was also updated. This PR contains the initial changes implemented inside of DEV-11215.
Technical details:
Since, Otel does not support filtering of traces and spans, there is some left over code that was being utilized with Datadog. That code has been left inside the tracing file in case of future uses but can be safely taken out if need be.
Additional Details:
Previously, we were able to perform some foundational work regarding the Grafana Migration from Datadog. Baseline functionality was implemented so UsaSpending API endpoints could be traced and relevant information such as traces could be ingested in Tempo and logging could be ingested in Loki. This goal was accomplished with DEV-11215.
This pull request is a recreation of this closed PR: #4221
Requirements for PR merge:
Area for explaining above N/A when needed: