cmake: Enable C++20 standard globally #1868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Globally enables C++20 rather than just for individual projects. This enables C++20 features across the whole code base rather just C++17 as a baseline. `std::result_of` was removed from the standard library as of C++20 and has been replaced with `std::invoke_result`.
|
This seems to be an interaction between UWP, SDL, and C++20: Looks like there was a related fix upstream here in SDL3: |
|
UWP builds use WinRT at the moment, so any C++20 features that touch these UWP related files will cause this error. Seems to be the only thing holding back this feature 😖. Not sure if UWP can be migrated to off of WinRT. |
|
We should probably stay with c++ 17 for now then. I was experimenting with std::filesystem and the new std::u8string of c++20 is a pain to work with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globally enables C++20 rather than just for individual projects. This enables C++20 features across the whole code base rather just C++17 as a baseline.
std::result_ofwas removed from the standard library as of C++20 and has been replaced withstd::invoke_result.https://en.cppreference.com/w/cpp/types/result_of