NEW (Extension) @W-17831303@ Fix release branch creation issue

[jag-j]

No description provided.

[jag-j]

Not sure why we use yarn here instead of using --frozen-lockfile. Let me know if this was intentional.

[stephen-carter-at-sf]

Yeah for consistency, we might want to just make this yarn install --frozen-lockfile like the others.

[jfeingold35]

Using --frozen-lockfile throughout probably isn't the worst idea.

[stephen-carter-at-sf]

For the preceding

    uses: actions/checkout@v4

step in other files, we have in

        with:
          token: ${{ secrets.IDEE_GH_TOKEN }} # So we can access internal repo to pull shared ui components

Why is this needed in the other files? I wouldn't think is needed to just do a clone of our repo.

Do we need to have that here in this file as well?

[stephen-carter-at-sf]

As discussed offline... we should instead try to remove all this git config update stuff... in favor of just using the token during checkout. But I believe this will require you to update the dependencies in the package.json file with

-        "einstein-shared": "https://github.com/forcedotcom/salesforcedx-vscode-einstein-shared#semver:0.3.10",
+        "salesforcedx-vscode-einstein-shared": "forcedotcom/salesforcedx-vscode-einstein-shared#semver:0.3.10",

and then rerun yarn install so that it updates the yarn.lock file. Then submit those updates and see if it fixes everything for us.

[stephen-carter-at-sf]

ditto... about the actions/checkout@v4 stuff

[stephen-carter-at-sf]

I wonder if it is worth creating a composite github action that for the checkout, node setup, and yarn install that we can just share all this across all our actions as a single looking action step.