fix(mpesa): Validate mPesa tax id format #2479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mat f tax id before initiating mpesa transaction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2479 +/- ##
==========================================
- Coverage 36.83% 36.67% -0.17%
==========================================
Files 403 407 +4
Lines 32152 32386 +234
==========================================
+ Hits 11843 11876 +33
- Misses 20309 20510 +201 ☔ View full report in Codecov by Sentry. |
shadrak98
requested changes
Feb 17, 2025
dashboard/src2/components/billing/mpesa/BuyPrepaidCreditsMpesa.vue
Outdated
Show resolved
Hide resolved
| if(this.taxIdInput){ | ||
| if (!pattern.test(this.taxIdInput)) { | ||
| throw new DashboardError( | ||
| "Tax ID should be in the format 'A123456789A'", |
There was a problem hiding this comment.
Don't show example Tax ID in the error message. Rather inform them about the correct format or just throw "invalid tax id".
Can you please also add somewhere in comment that this format is only applicable for Kenya?
|
@maniamartial Please setup pre-commit in your local before raising a PR for linting. |
shadrak98
changed the title
shadrak98
approved these changes
Mar 12, 2025
|
@maniamartial is this ready to merge? |
|
@shadrak98 Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tax id starts should start with capital letter, also end in capital letter and in between contain 8 numerical numbers.
Validating this using regez expression before initiating a transaction.
eg .