Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bare-metal): press on bare metal #2540

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AlenVelocity
Copy link

@AlenVelocity AlenVelocity commented Mar 20, 2025

Remaining Tasks

  • Merge Bare Metal VM DocType into Virtual Machine
    • Drop Bare Metal VM DocType
    • [-] Implement remaining actions in Virtual Machine
  • [] Bare Metal Host
    • Use BaseServer (for Ansible and Agent)
    • Most VM actions take longer than a second to complete. Move them to Agent Job
    • Write playbooks for setting up bare-metal machines
    • [-] Bring all actions from Sever doctype to Bare Metal Host and make ansible support (prepare, setup etc)
  • [-] Move vm-experiments endpoints to Agent (Progress)

@AlenVelocity AlenVelocity changed the title feat(bare-metal): press on bare metal inital feat(bare-metal): press on bare metal Mar 20, 2025
@AlenVelocity AlenVelocity marked this pull request as draft March 20, 2025 11:02
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 25.87065% with 298 lines in your changes missing coverage. Please review.

Project coverage is 36.28%. Comparing base (a749a54) to head (0754c84).
Report is 151 commits behind head on master.

Files with missing lines Patch % Lines
...s/press/doctype/bare_metal_host/bare_metal_host.py 28.21% 257 Missing ⚠️
...s/press/doctype/virtual_machine/virtual_machine.py 6.81% 41 Missing ⚠️

❌ Your patch check has failed because the patch coverage (25.87%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   36.60%   36.28%   -0.33%     
==========================================
  Files         407      412       +5     
  Lines       32730    33470     +740     
==========================================
+ Hits        11982    12144     +162     
- Misses      20748    21326     +578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant